bpo-37111: Added encoding keyword parameter to basicConfig.#13932
Closed
vsajip wants to merge 12 commits into
Closed
bpo-37111: Added encoding keyword parameter to basicConfig.#13932vsajip wants to merge 12 commits into
vsajip wants to merge 12 commits into
Conversation
Member
Author
|
@zooba Please review just to ensure I haven't missed anything ... thanks. |
Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue37215
Member
|
@vsajip We normally add |
Member
|
To be clear, I mean you should add an |
Member
Author
|
Whoops, I made a mistake by doing a rebase - should I just kill this PR and start again? |
Member
|
@vsajip Yeah, looks like you undid some other changes, so probably best to restart. FWIW, once you submit a PR and people start looking it at, you're best to just do regular merges and we'll squash it all at the end. That way you don't break the review workflow. |
Member
Author
|
That's what I normally do, I just had a brain-fade this time :-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37111