[3.8] bpo-37150: Throw ValueError if FileType class object was passed in add_argument (GH-13805)#13901
Merged
Conversation
…d_argument (pythonGH-13805) There is a possibility that someone (like me) accidentally will omit parentheses with `FileType` arguments after `FileType`, and parser will contain wrong file until someone will try to use it. Example: ```python parser = argparse.ArgumentParser() parser.add_argument('-x', type=argparse.FileType) ``` https://bugs.python.org/issue37150 (cherry picked from commit 03d5831) Co-authored-by: zygocephalus <grrrr@protonmail.com>
Contributor
Author
|
@zygocephalus: Status check is done, and it's a success ✅ . |
2 similar comments
Contributor
Author
|
@zygocephalus: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@zygocephalus: Status check is done, and it's a success ✅ . |
asvetlov
approved these changes
Jun 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a possibility that someone (like me) accidentally will omit parentheses with
FileTypearguments afterFileType, and parser will contain wrong file until someone will try to use it.Example:
https://bugs.python.org/issue37150
(cherry picked from commit 03d5831)
Co-authored-by: zygocephalus grrrr@protonmail.com
https://bugs.python.org/issue37150