Skip to content

bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method()#13865

Merged
methane merged 2 commits into
python:masterfrom
jdemeyer:pep590_lookup_maybe_method
Jun 17, 2019
Merged

bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method()#13865
methane merged 2 commits into
python:masterfrom
jdemeyer:pep590_lookup_maybe_method

Conversation

@jdemeyer

@jdemeyer jdemeyer commented Jun 6, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

lookup_maybe_method is an obvious place where the use case of Py_TPFLAGS_METHOD_DESCRIPTOR applies.

IMHO, this is safe enough for 3.8 but the reviewer should judge that.

CC @encukou @vstinner

https://bugs.python.org/issue36922

@jdemeyer

jdemeyer commented Jun 14, 2019

Copy link
Copy Markdown
Contributor Author

CC @methane

@methane
methane merged commit 2e9954d into python:master Jun 17, 2019
@miss-islington

miss-islington commented Jun 17, 2019

Copy link
Copy Markdown
Contributor

Thanks @jdemeyer for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 17, 2019

Copy link
Copy Markdown

GH-14155 is a backport of this pull request to the 3.8 branch.

@methane

methane commented Jun 17, 2019

Copy link
Copy Markdown
Member

OK, I think this is safe enough, and this is part of PEP 590 implementation.
Polishing a new feature in beta period is allowed when it is safe enough.

@jdemeyer

jdemeyer commented Jun 17, 2019

Copy link
Copy Markdown
Contributor Author

Thanks!

@jdemeyer
jdemeyer deleted the pep590_lookup_maybe_method branch June 17, 2019 11:55
miss-islington added a commit that referenced this pull request Jun 17, 2019
@miss-islington @jdemeyer
bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() (G…
988fff5 
…H-13865)

(cherry picked from commit 2e9954d)

Co-authored-by: Jeroen Demeyer <J.Demeyer@UGent.be>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@jdemeyer @lisroach
bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() (p…
ebda540 
…ythonGH-13865)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@jdemeyer @DinoV
bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() (p…
2386b28 
…ythonGH-13865)
@mmcqd mmcqd mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mangrisano mangrisano mangrisano approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jdemeyer @miss-islington @bedevere-bot @methane @mangrisano @the-knights-who-say-ni