I think we can skip the news entry on this tiny fix

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

May I convince you to look again instead? It’s 4 lines of very simple code…

1. We go into the branch when object is a class
2. object gets reassigned to the class’ module
3. An error gets thrown, with the message talking about the class.

I simply introduce a new variable instead of reassigning object, so it stays assigned to the class and the error message is correct.

I agree that the change appears to be is correct, as explained. See the end below.

In general, bpo issues get blurbs. A bugfix like this needs a blurb so that anyone who has run into it will see that it is fixed. We are not starved for news space. "The exception message for inspect.getfile() now correctly reports the class rather than module builtins.

test_inspect needs 3 new methods added after test_getfile:

    def test_getfile_builtin_module(self):
        with self.assertRaises(TypeError) as e:
            inspect.getfile(sys)
        self.assertTrue(str(e.exception).startswith('<module'))

    def test_getfile_builtin_class(self):
        with self.assertRaises(TypeError) as e:
            inspect.getfile(int)
        self.assertTrue(str(e.exception).startswith('<class'))

    def test_getfile_builtin_function_or_method(self):
        with self.assertRaises(TypeError) as e:
            inspect.getfile(abs)
        self.assertIn('expected, got', str(e.exception))
        with self.assertRaises(TypeError) as e:
            inspect.getfile(list.append)
        self.assertIn('expected, got', str(e.exception))

Note that test_getfile_builtin_class current fails because the message currently starts with '<module'. The patch should make it pass.

OK, I was opposed to just add a test for the thing I fixed (basically as a regression test for a trivial change), but proposing that the whole thing ought to be tested makes sense to me. I’ll add both news and tests

@asvetlov OK, done

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

Thanks @flying-sheep for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

GH-13913 is a backport of this pull request to the 3.8 branch.

Great! Thank you for the tests @terryjreedy

Thanks @flying-sheep for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

GH-13918 is a backport of this pull request to the 3.7 branch.

@flying-sheep Our general policy is to add an initially failing test, to prevent a regression, for every bugfix.