bpo-30229: BufferedRandom.flush() avoids lseek#1386
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
BufferedRandom flush() and close() don't call lseek() syscall anymore if the read and write buffers are empty.
|
@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @serhiy-storchaka and @shibturn to be potential reviewers. |
Member
Author
|
@pitrou : would you mind to review this change? I guess that you wrote that code ;-) |
Member
|
I'm not sure it's a good idea to change this code if there is not a pressing need. Which performance difference do you see? |
Member
Author
|
I'm not sure it's a good idea to change this code if there is not a pressing need. Which performance difference do you see?
I only counted the number of syscalls :-) I didn't run any bennchmark yet.
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BufferedRandom flush() and close() don't call lseek() syscall anymore if the read and write buffers are empty.