Skip to content

bpo-34767: Do not always create a collections.deque() in asyncio.Lock()#13834

Merged
miss-islington merged 2 commits into
python:masterfrom
ZackerySpytz:bpo-34767-asyncio-Lock-opt
Jun 5, 2019
Merged

bpo-34767: Do not always create a collections.deque() in asyncio.Lock()#13834
miss-islington merged 2 commits into
python:masterfrom
ZackerySpytz:bpo-34767-asyncio-Lock-opt

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Jun 5, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

asvetlov
asvetlov requested changes Jun 5, 2019
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please fix the minor comment

Comment thread Lib/asyncio/locks.py Outdated
@bedevere-bot

bedevere-bot commented Jun 5, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington

miss-islington commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

@ZackerySpytz: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit 9aa7856 into python:master Jun 5, 2019
@miss-islington

miss-islington commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 5, 2019

Copy link
Copy Markdown

GH-13837 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 5, 2019
@miss-islington @ZackerySpytz
bpo-34767: Do not always create a collections.deque() in asyncio.Lock…
87a865e 
…() (GH-13834)

https://bugs.python.org/issue34767
(cherry picked from commit 9aa7856)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@ZackerySpytz @DinoV
bpo-34767: Do not always create a collections.deque() in asyncio.Lock…
e5de344 
…() (pythonGH-13834)

https://bugs.python.org/issue34767
@jeffguorg jeffguorg mentioned this pull request Mar 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes
@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZackerySpytz @bedevere-bot @miss-islington @asvetlov @the-knights-who-say-ni