Skip to content

gh-137058: use __STDC_VERSION__ >= 202311L instead of __STDC_VERSION__ > 201710L#137127

Merged
picnixz merged 1 commit into
python:mainfrom
abdoulrasheed:update-c23-stdc-version-check-137058
Jul 27, 2025
Merged

gh-137058: use __STDC_VERSION__ >= 202311L instead of __STDC_VERSION__ > 201710L#137127
picnixz merged 1 commit into
python:mainfrom
abdoulrasheed:update-c23-stdc-version-check-137058

Conversation

@abdoulrasheed

@abdoulrasheed abdoulrasheed commented Jul 26, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@python-cla-bot

python-cla-bot Bot commented Jul 26, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Jul 26, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app Bot mentioned this pull request Jul 26, 2025
Closed
@picnixz picnixz merged commit cfd6da8 into python:main Jul 27, 2025
47 of 48 checks passed
@picnixz

picnixz commented Jul 27, 2025

Copy link
Copy Markdown
Member

@hugovk Your pick on whether you want this to be backported. It's not really an issue but it helps reducing the diff between 3.14 and 3.15.

@vstinner

vstinner commented Aug 5, 2025

Copy link
Copy Markdown
Member

IMO it's worth it to backport the change, but it can wait for Python 3.14.1.

@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Aug 5, 2025
@miss-islington-app

miss-islington-app Bot commented Aug 5, 2025

Copy link
Copy Markdown

Thanks @abdoulrasheed for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Aug 5, 2025

Copy link
Copy Markdown

Sorry, @abdoulrasheed and @picnixz, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cfd6da849a3c40904cddd23ae1700605877673fb 3.14

@vstinner

vstinner commented Aug 5, 2025

Copy link
Copy Markdown
Member

I created #137409 to update _Py_NULL in the 3.14 branch.

@serhiy-storchaka

serhiy-storchaka commented Aug 14, 2025

Copy link
Copy Markdown
Member

Reminder about backporting. @abdoulrasheed @picnixz

@encukou encukou removed the needs backport to 3.14 bugs and security fixes label Aug 15, 2025
@encukou encukou mentioned this pull request Aug 15, 2025
Merged
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@abdoulrasheed @Agent-Hellboy
pythongh-137058: Update C23 standard version check in pyport.h (pyt…
8404e42 
…hon#137127)

Use `__STDC_VERSION__ >= 202311L` instead of `__STDC_VERSION__ > 201710L`.
@vstinner

vstinner commented Sep 1, 2025

Copy link
Copy Markdown
Member

Reminder about backporting. @abdoulrasheed @picnixz

I created a backport to 3.14. Do you mean that we should backport the change to 3.13 as well?

@serhiy-storchaka

serhiy-storchaka commented Sep 1, 2025

Copy link
Copy Markdown
Member

There was only label for 3.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abdoulrasheed @picnixz @vstinner @serhiy-storchaka @encukou