gh-136523: fix wave.Wave_write emitting an unraisable when open raises#136529
Merged
serhiy-storchaka merged 7 commits intopython:mainfrom Jul 13, 2025
Merged
gh-136523: fix wave.Wave_write emitting an unraisable when open raises#136529serhiy-storchaka merged 7 commits intopython:mainfrom
serhiy-storchaka merged 7 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
LamentXU123
reviewed
Jul 11, 2025
Misc/NEWS.d/next/Library/2025-07-11-03-39-15.gh-issue-136523.s7caKL.rst
Outdated
Show resolved
Hide resolved
inventshah
changed the title
serhiy-storchaka
approved these changes
Jul 13, 2025
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
Thank you for your contribution, @inventshah.
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @inventshah for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2025
… raises (pythonGH-136529) (cherry picked from commit 171de05) Co-authored-by: Sachin Shah <39803835+inventshah@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2025
… raises (pythonGH-136529) (cherry picked from commit 171de05) Co-authored-by: Sachin Shah <39803835+inventshah@users.noreply.github.com>
|
GH-136606 is a backport of this pull request to the 3.14 branch. |
|
GH-136607 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jul 13, 2025
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jul 16, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…en open raises (pythonGH-136529) (pythonGH-136606) (cherry picked from commit 171de05) Co-authored-by: Sachin Shah <39803835+inventshah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136523, by moving
builtins.openinside thetry-exceptblock and always callinginitfp(which does not raise) forWave_write.Wave_write.__del__()after failed attempt to open file for write operation #136523