Skip to content

bpo-37049: PEP 589: Add TypedDict to typing module#13573

Merged
ilevkivskyi merged 6 commits into
python:masterfrom
ilevkivskyi:add-typeddict
May 26, 2019
Merged

bpo-37049: PEP 589: Add TypedDict to typing module#13573
ilevkivskyi merged 6 commits into
python:masterfrom
ilevkivskyi:add-typeddict

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented May 25, 2019

Copy link
Copy Markdown
Member

cc @JukkaL

The implementation is straightforward and essentially is just copied from typing_extensions.

https://bugs.python.org/issue37049

Comment thread Doc/library/typing.rst Outdated
Comment thread Doc/library/typing.rst Outdated
Comment thread Doc/library/typing.rst Outdated
Comment thread Doc/library/typing.rst Outdated
Comment thread Lib/test/test_typing.py Outdated
Comment thread Lib/test/test_typing.py Outdated
Comment thread Lib/typing.py Outdated
Comment thread Lib/typing.py Outdated

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilevkivskyi
ilevkivskyi merged commit 135c6a5 into python:master May 26, 2019
@ilevkivskyi
ilevkivskyi deleted the add-typeddict branch May 26, 2019 08:39
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
The implementation is straightforward and essentially is just copied from `typing_extensions`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants