bpo-37045: PEP 591: Add final qualifiers to typing module#13571
Merged
Conversation
gvanrossum
approved these changes
May 25, 2019
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Just some doc nits. (The PR is almost all docs anyway. ;-) Feel free to fix those and merge.
msullivan
approved these changes
May 26, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…3571) The implementation is straightforward, it just mimics `ClassVar` (since the latter is also a name/access qualifier, not really a type). Also it is essentially copied from `typing_extensions`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @msullivan
The implementation is straightforward, it just mimics
ClassVar(since the latter is also a name/access qualifier, not really a type). Also it is essentially copied fromtyping_extensions.https://bugs.python.org/issue37045