Skip to content

gh-135379: Add back const cast to _PyLong_IsCompact #135706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 2 commits into from
Jun 19, 2025
Merged

gh-135379: Add back const cast to _PyLong_IsCompact #135706

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
991c098
Add back const cast to _PyLong_IsCompact
Fidget-Spinner Jun 19, 2025
219d9d1
remove const
Fidget-Spinner Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Include/cpython/longintrepr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,9 @@ _PyLong_IsCompact(const PyLongObject* op) {
}

static inline int
PyLong_CheckCompact(const PyObject *op)
PyLong_CheckCompact(PyObject *op)
Copy link
Member Author

@Fidget-Spinner Fidget-Spinner Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use PyObject * here because PyLong_CheckExact casts to PyObject * which discards the const qualifier.

{
return PyLong_CheckExact(op) && _PyLong_IsCompact((PyLongObject *)op);
return PyLong_CheckExact(op) && _PyLong_IsCompact((const PyLongObject *)op);
}

#define PyUnstable_Long_IsCompact _PyLong_IsCompact
Expand Down
Loading