Skip to content

bpo-30206: restore *data* parameter of binascii.b2a_base64 to positional-only #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhangyangyu merged 1 commit into from
May 1, 2017
Merged

bpo-30206: restore *data* parameter of binascii.b2a_base64 to positional-only #1352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Modules/binascii.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,7 @@ binascii_a2b_base64_impl(PyObject *module, Py_buffer *data)
binascii.b2a_base64

data: Py_buffer
/
*
newline: bool(accept={int}) = True

Expand All @@ -523,7 +524,7 @@ Base64-code line of data.

static PyObject *
binascii_b2a_base64_impl(PyObject *module, Py_buffer *data, int newline)
/*[clinic end generated code: output=4ad62c8e8485d3b3 input=144fd7267a34d51c]*/
/*[clinic end generated code: output=4ad62c8e8485d3b3 input=6083dac5777fa45d]*/
{
unsigned char *ascii_data;
const unsigned char *bin_data;
Expand Down
6 changes: 3 additions & 3 deletions Modules/clinic/binascii.c.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ binascii_a2b_base64(PyObject *module, PyObject *arg)
}

PyDoc_STRVAR(binascii_b2a_base64__doc__,
"b2a_base64($module, /, data, *, newline=True)\n"
"b2a_base64($module, data, /, *, newline=True)\n"
"--\n"
"\n"
"Base64-code line of data.");
Expand All @@ -112,7 +112,7 @@ static PyObject *
binascii_b2a_base64(PyObject *module, PyObject **args, Py_ssize_t nargs, PyObject *kwnames)
{
PyObject *return_value = NULL;
static const char * const _keywords[] = {"data", "newline", NULL};
static const char * const _keywords[] = {"", "newline", NULL};
static _PyArg_Parser _parser = {"y*|$i:b2a_base64", _keywords, 0};
Py_buffer data = {NULL, NULL};
int newline = 1;
Expand Down Expand Up @@ -558,4 +558,4 @@ binascii_b2a_qp(PyObject *module, PyObject **args, Py_ssize_t nargs, PyObject *k

return return_value;
}
/*[clinic end generated code: output=4a418f883ccc79fe input=a9049054013a1b77]*/
/*[clinic end generated code: output=35821bce7e0e4714 input=a9049054013a1b77]*/