bpo-36829: PyErr_WriteUnraisable() normalizes exception#13507
Merged
vstinner merged 3 commits intopython:masterfrom May 22, 2019
vstinner:unraisablehook_traceback
Merged
bpo-36829: PyErr_WriteUnraisable() normalizes exception#13507vstinner merged 3 commits intopython:masterfrom vstinner:unraisablehook_traceback
vstinner merged 3 commits intopython:masterfrom
vstinner:unraisablehook_traceback
Conversation
PyErr_WriteUnraisable() now creates a traceback object if there is no current traceback. Moreover, call PyErr_NormalizeException() and PyException_SetTraceback() to normalize the exception value. Ignore any error.
Replace runtime check with assertions. _PyTraceBack_FromFrame() is used by PyTraceBack_Here() which is performance critical (called from ceval.c).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyErr_WriteUnraisable() now creates a traceback object if there is no
current traceback. Moreover, call PyErr_NormalizeException() and
PyException_SetTraceback() to normalize the exception value.
https://bugs.python.org/issue36829