bpo-36984: Improve version added references in typing module docs#13457
Conversation
| A generic version of :class:`collections.deque`. | ||
|
|
||
| .. versionadded:: 3.5.4 | ||
| .. versionadded:: 3.6.1 |
There was a problem hiding this comment.
Why is there 2 "versionadded" here ? was this added both ein 3.5.4 and 3.6.1 ? Meaning it's not in 3.6.0 ?
If that's the case that might look like a typo in the docs from a casual reader, and might need a clarification paragraph.
There was a problem hiding this comment.
that's correct! it is pretty weird!
There was a problem hiding this comment.
Yeah, the story with versions is related to the fact that typing module used to be provisional, so features were added at random time, even between minor releases.
| A generic version of :class:`collections.Counter`. | ||
|
|
||
| .. versionadded:: 3.5.4 | ||
| .. versionadded:: 3.6.1 |
There was a problem hiding this comment.
Same on all of these; that feel super weird;
Carreau
left a comment
Carreau
left a comment
There was a problem hiding this comment.
Version added are always super useful.
| A generic version of :class:`collections.deque`. | ||
|
|
||
| .. versionadded:: 3.5.4 | ||
| .. versionadded:: 3.6.1 |
There was a problem hiding this comment.
Yeah, the story with versions is related to the fact that typing module used to be provisional, so features were added at random time, even between minor releases.
|
Thanks @asottile for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
) (cherry picked from commit b7daabd) Co-authored-by: Anthony Sottile <asottile@umich.edu>
|
GH-13737 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit b7daabd) Co-authored-by: Anthony Sottile <asottile@umich.edu>
6 participants
https://bugs.python.org/issue36984