bpo-36969: Make PDB args command display keyword only arguments#13452
Merged
pablogsal merged 2 commits intoMay 20, 2019
Merged
Conversation
remilapeyre
changed the title
pablogsal
reviewed
May 20, 2019
| n = co.co_argcount | ||
| if co.co_flags & 4: n = n+1 | ||
| if co.co_flags & 8: n = n+1 | ||
| n = co.co_argcount + co.co_kwonlyargcount |
Member
There was a problem hiding this comment.
You also need to add co.co_posonlyargcount to handle PEP570 (check the issue). Although this will difficult backporting, so maybe you want this to be done in a separate PR.
Author
There was a problem hiding this comment.
Thank @pablogsal, it may be simple to do so in a separate PR I think.
pablogsal
reviewed
May 20, 2019
| co = self.curframe.f_code | ||
| dict = self.curframe_locals | ||
| n = co.co_argcount | ||
| if co.co_flags & 4: n = n+1 |
Member
There was a problem hiding this comment.
Thanks for removing these evil magic numbers!
Author
There was a problem hiding this comment.
Definitely the improvement Python needed ^^
pablogsal
approved these changes
May 20, 2019
Contributor
|
Thanks @remilapeyre for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2019
…onGH-13452) (cherry picked from commit bf457c7) Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
|
GH-13453 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
May 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36969