bpo-29883: Asyncio proactor udp#13440
Merged
Merged
Conversation
…o asyncio-proactor-udp
asvetlov
marked this pull request as ready for review
May 25, 2019 12:52
Contributor
Author
|
@vstinner would you review this PR? If you have no time please let me know anyway. It is a continuation of #1067 with the following differences:
I believe that the Pull Request is written well and ready for merging. |
tirkarthi
reviewed
May 26, 2019
Co-Authored-By: Xtreak <tir.karthi@gmail.com>
auvipy
approved these changes
May 26, 2019
1st1
reviewed
May 28, 2019
1st1
reviewed
May 28, 2019
| return NULL; | ||
| } | ||
|
|
||
| Py_BEGIN_ALLOW_THREADS |
Member
There was a problem hiding this comment.
If WSAConnect returns immediately, do we need to release GIL?
Contributor
Author
There was a problem hiding this comment.
Technically it is a syscall.
We have the practice to release GIL on socket.bind() for example
1st1
approved these changes
May 28, 2019
1st1
left a comment
1st1
left a comment
Member
There was a problem hiding this comment.
Looks good. Merge with caution as I'm not a Windows expert.
auvipy
approved these changes
May 28, 2019
auvipy
approved these changes
May 28, 2019
Contributor
Author
|
Thank you very much @ameily |
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #1067
https://bugs.python.org/issue29883