Repository navigation
gh-134309: Fix premature cancellation of CI tests when multiple PRs have the same branch name - #134310
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per GitHub, "When you define a concurrency key, GitHub Actions ensures that only one workflow or job with that key runs at any given time." Under the current config, concurrency group names for pull requests are made unique (against those of other pull requests) only by the name of the branch, so if pull requests were made for identically named branches around the same time, CI would fail. (This affected commit #134234 )
This PR addresses that by using more unique attributes to name each concurrency group. This should also help with debugging any future issues that concern the name of a concurrency group.