Skip to content

bpo-33524: Fix the folding of email header when max_line_length is 0 or None#13391

Merged
bitdancer merged 3 commits intopython:masterfrom
maxking:bpo-33524
May 17, 2019
Merged

bpo-33524: Fix the folding of email header when max_line_length is 0 or None#13391
bitdancer merged 3 commits intopython:masterfrom
maxking:bpo-33524

Conversation

@maxking
Copy link
Copy Markdown
Contributor

@maxking maxking commented May 17, 2019 •
edited by bedevere-bot
Loading

Updated version of #6966 with requested NEWS entry since that PR looks abandoned.

Original Patch by @Licht-T

https://bugs.python.org/issue33524

@maxking maxking requested a review from a team as a code owner May 17, 2019 18:48
bitdancer
bitdancer requested changes May 17, 2019
View reviewed changes
Misc/NEWS.d/next/Library/2019-05-17-11-44-21.bpo-33524.8y_xUU.rst Outdated
Copy link
Copy Markdown
Member

@bitdancer bitdancer May 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear about what we are fixing this probably ought to say "...is 0 or None and the header contains non-ascii characters".

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 17, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@maxking
Copy link
Copy Markdown
Contributor Author

maxking commented May 17, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 17, 2019

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

@bitdancer bitdancer merged commit feac6cd into python:master May 17, 2019
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 17, 2019

@bitdancer: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 17, 2019

Thanks @maxking for the PR, and @bitdancer for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 17, 2019
@maxking @miss-islington
bpo-33524: Fix the folding of email header when max_line_length is 0 …
7e23a1b 
…or None (pythonGH-13391)

and there are non-ascii characters in the header.
(cherry picked from commit feac6cd)

Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 17, 2019

GH-13393 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 17, 2019
@miss-islington @maxking
bpo-33524: Fix the folding of email header when max_line_length is 0 …
5386aaf 
…or None (GH-13391)

and there are non-ascii characters in the header.
(cherry picked from commit feac6cd)

Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
@janotomko janotomko mentioned this pull request Sep 21, 2020
Merged
stefano-garzarella added a commit to stefano-garzarella/git-publish that referenced this pull request Sep 21, 2020
@stefano-garzarella
workflows: use python 3.8
290cfe4 
With default python (3.6) we had this issue:
python/cpython#13391

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
stefanha pushed a commit to stefanha/git-publish that referenced this pull request Sep 21, 2020
@stefano-garzarella @stefanha
workflows: use python 3.8
251defc 
With default python (3.6) we had this issue:
python/cpython#13391

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitdancer bitdancer bitdancer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maxking @bedevere-bot @miss-islington @bitdancer @the-knights-who-say-ni @Licht-T