Skip to content

bpo-36260: Add pitfalls to zipfile module documentation#13378

Merged
jaraco merged 4 commits into
python:masterfrom
krnick:master
Sep 11, 2019
Merged

bpo-36260: Add pitfalls to zipfile module documentation#13378
jaraco merged 4 commits into
python:masterfrom
krnick:master

Conversation

@krnick

@krnick krnick commented May 17, 2019

Copy link
Copy Markdown
Contributor

We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file.
This gave us the idea of documentation improvement.

So, we moved a little bit forward :D

https://bugs.python.org/issue36260

We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file.
This gave us the idea of documentation improvement. 

So, we moved a little bit forward :P
And the doc patch can be found (pr).
@csabella

csabella commented Jun 1, 2019

Copy link
Copy Markdown
Contributor

@krnick, your pull request is failing the CI builds because of trailing whitespace. Please correct that. Thank you!

@krnick

krnick commented Jun 1, 2019

Copy link
Copy Markdown
Contributor Author

@csabella Sorry for the mistake, I have fixed it.

@csabella

csabella commented Jun 2, 2019

Copy link
Copy Markdown
Contributor

Request review from @tiran and @serhiy-storchaka based on this discussion on the bug tracker.

@jaraco jaraco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @tiran, we're happy to include this section. I've done some minor reformatting for consistency.

@jaraco
jaraco merged commit 3ba51d5 into python:master Sep 11, 2019
@bedevere-bot

Copy link
Copy Markdown

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @krnick for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
* bpo-36260: Add pitfalls to zipfile module documentation

We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file.
This gave us the idea of documentation improvement.

So, we moved a little bit forward :P
And the doc patch can be found (pr).

* fix trailing whitespace

* 📜🤖 Added by blurb_it.

* Reformat text for consistency.
(cherry picked from commit 3ba51d5)

Co-authored-by: JunWei Song <sungboss2004@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-15976 is a backport of this pull request to the 3.8 branch.

jaraco pushed a commit that referenced this pull request Sep 11, 2019
…H-15976)

* bpo-36260: Add pitfalls to zipfile module documentation

We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file.
This gave us the idea of documentation improvement.

So, we moved a little bit forward :P
And the doc patch can be found (pr).

* fix trailing whitespace

* 📜🤖 Added by blurb_it.

* Reformat text for consistency.
(cherry picked from commit 3ba51d5)

Co-authored-by: JunWei Song <sungboss2004@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
* bpo-36260: Add pitfalls to zipfile module documentation

We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file.
This gave us the idea of documentation improvement. 

So, we moved a little bit forward :P
And the doc patch can be found (pr).

* fix trailing whitespace

* 📜🤖 Added by blurb_it.

* Reformat text for consistency.
tkarabela added a commit to tkarabela/cpython that referenced this pull request Nov 30, 2022
Co-authored-by: Florent Xicluna <florent.xicluna@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants