gh-133379: Correct usage of arguments in error messages#133382
Merged
Conversation
StanFromIreland
requested review from
JelleZijlstra,
ambv,
carljm,
lysnikolaou and
pablogsal
as code owners
JelleZijlstra
approved these changes
May 4, 2025
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Title looks great to me
picnixz
approved these changes
May 4, 2025
Member
|
The title could be about correcting the places where the term argument is incorrectly used, but your title is fine. |
Member
Member
Author
|
Other error messages are corrected. |
Member
|
Following #133463 (comment), I suggest we fix everything here. |
Member
Author
|
All complete, I included @serhiy-storchaka extra example and two more I found. Added an entry to whatsnew since this affects quite a few error messages. |
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…pythonGH-133382) The right term is "parameters".
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…pythonGH-133382) The right term is "parameters".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not quite sure what the title should be for this.
argumentinstead ofparameter#133379