gh-133367: Add missing options to ast CLI#133369
Merged
sobolevn merged 13 commits intopython:mainfrom May 5, 2025
Merged
Conversation
donbarbos
requested review from
Eclips4,
JelleZijlstra and
isidentical
as code owners
sobolevn
reviewed
May 4, 2025
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Please, don't forget to add tests in your other PR
tomasr8
reviewed
May 4, 2025
Member
Probably, that one (i.e. #133329) should be merged first. |
JelleZijlstra
approved these changes
May 4, 2025
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
picnixz
reviewed
May 4, 2025
sobolevn
reviewed
May 4, 2025
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Now please rebase this PR and add tests :)
Misc/NEWS.d/next/Library/2025-05-04-13-40-05.gh-issue-133367.E5nl2u.rst
Outdated
Show resolved
Hide resolved
…5nl2u.rst Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
hugovk
approved these changes
May 5, 2025
sobolevn
approved these changes
May 5, 2025
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
One more suggestion: let's add defaults to the docs.
sobolevn
reviewed
May 5, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: sobolevn <mail@sobolevn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't sure about adding whatsnew entry but I added it so we can remote it
*Headings were corrected according to the devguide
cc @sobolevn
astCLI with new options:--feature-version,--optimize, and--show-empty#133367📚 Documentation preview 📚: https://cpython-previews--133369.org.readthedocs.build/