[3.7] Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)"#13328
Merged
vstinner merged 1 commit intopython:3.7from May 14, 2019
vstinner:revert_asyncio_ssl37
Merged
[3.7] Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)"#13328vstinner merged 1 commit intopython:3.7from vstinner:revert_asyncio_ssl37
vstinner merged 1 commit intopython:3.7from
vstinner:revert_asyncio_ssl37
Conversation
Member
Author
|
The revert is motivated by https://bugs.python.org/issue36870 : test_asyncio fails randomly which causes a lot of pain in the Python CI and the Python workflow. See: |
asvetlov
approved these changes
May 14, 2019
Contributor
Member
Author
This revert is for Python 3.7. |
Contributor
|
Sorry, I mean the same code should be reverted on the master too |
Member
Author
|
Without this change, I easily reproduce the failure on Windows: With this change, the test pass as expected: |
Contributor
|
Cool! |
Member
Author
Well, I don't know yet if PR #13313 fixed https://bugs.python.org/issue36870 on master. Anyway, I created PR #13329 for master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 93aa57a.
https://bugs.python.org/issue36801