bpo-36817: Fix reference leak for expr_text in f-string = parsing#13249
Merged
Conversation
pablogsal
requested review from
ericvsmith,
ilevkivskyi and
larryhastings
and removed request for
ilevkivskyi
May 11, 2019 17:18
Member
Author
|
❯ ./python -m test test_future -m test_annotations -R : == Tests result: SUCCESS == 1 test OK. Total duration: 324 ms |
ilevkivskyi
approved these changes
May 11, 2019
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! LGTM.
ericvsmith
approved these changes
May 11, 2019
ericvsmith
left a comment
ericvsmith
left a comment
Member
There was a problem hiding this comment.
Thanks for catching this. I kept thinking "I need to remember to make sure that memory gets freed", and then I forgot to do it.
pablogsal
force-pushed
the
refleak_fstring
branch
from
May 11, 2019 19:00
291ca6f to
1094a6b
Compare
Member
Author
|
I am restarting the CI because appveyor failed with some random asyncio error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36817