Skip to content

bpo-32587: Make winreg.REG_MULTI_SZ support zero-length strings#13239

Merged
zooba merged 2 commits into
python:masterfrom
ZackerySpytz:bpo-32587-winreg-REG_MULTI_SZ
Sep 9, 2019
Merged

bpo-32587: Make winreg.REG_MULTI_SZ support zero-length strings#13239
zooba merged 2 commits into
python:masterfrom
ZackerySpytz:bpo-32587-winreg-REG_MULTI_SZ

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented May 10, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@ZackerySpytz
ZackerySpytz requested a review from a team as a code owner May 10, 2019 21:32
@ZackerySpytz

ZackerySpytz commented May 10, 2019

Copy link
Copy Markdown
Contributor Author

This PR currently lacks a unit test, mainly because using MoveFileExA() with MOVEFILE_DELAY_UNTIL_REBOOT requires administrative rights. @eryksun, your insight would be appreciated here.
I've tested this patch locally with a modified version of the rtlqueryreg.py script on the BPO issue.
Also, this PR should fix the issue with wcslen() mentioned in https://bugs.python.org/issue9194#msg339465.

eryksun
eryksun reviewed May 11, 2019
View reviewed changes
Comment thread PC/winreg.c
eryksun
eryksun reviewed May 11, 2019
View reviewed changes
Comment thread PC/winreg.c Outdated
@ZackerySpytz ZackerySpytz changed the title bpo-32587: Make winreg.REG_MULTI_SZ support PendingFileRenameOperations bpo-32587: Make winreg.REG_MULTI_SZ support zero-length strings May 14, 2019
@zooba
zooba merged commit e223ba1 into python:master Sep 9, 2019
@bedevere-bot

bedevere-bot commented Sep 9, 2019

Copy link
Copy Markdown

@zooba: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
@ZackerySpytz @miss-islington
bpo-32587: Make winreg.REG_MULTI_SZ support zero-length strings (pyth…
1fd2d1f 
…onGH-13239)

* bpo-32587: Make winreg.REG_MULTI_SZ support PendingFileRenameOperations

* Address review comments.
(cherry picked from commit e223ba1)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 9, 2019

Copy link
Copy Markdown

GH-15745 is a backport of this pull request to the 3.7 branch.

@miss-islington

miss-islington commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
@ZackerySpytz @miss-islington
bpo-32587: Make winreg.REG_MULTI_SZ support zero-length strings (pyth…
46530b6 
…onGH-13239)

* bpo-32587: Make winreg.REG_MULTI_SZ support PendingFileRenameOperations

* Address review comments.
(cherry picked from commit e223ba1)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 9, 2019

Copy link
Copy Markdown

GH-15746 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 9, 2019
@miss-islington @ZackerySpytz
bpo-32587: Make winreg.REG_MULTI_SZ support zero-length strings (GH-1…
bbf02da 
…3239)

* bpo-32587: Make winreg.REG_MULTI_SZ support PendingFileRenameOperations

* Address review comments.
(cherry picked from commit e223ba1)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Sep 9, 2019
@miss-islington @ZackerySpytz
bpo-32587: Make winreg.REG_MULTI_SZ support zero-length strings (GH-1…
ebca7eb 
…3239)

* bpo-32587: Make winreg.REG_MULTI_SZ support PendingFileRenameOperations

* Address review comments.
(cherry picked from commit e223ba1)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@ZackerySpytz @lisroach
bpo-32587: Make winreg.REG_MULTI_SZ support zero-length strings (pyth…
e4ae55d 
…on#13239)

* bpo-32587: Make winreg.REG_MULTI_SZ support PendingFileRenameOperations

* Address review comments.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@ZackerySpytz @DinoV
bpo-32587: Make winreg.REG_MULTI_SZ support zero-length strings (pyth…
41815cd 
…on#13239)

* bpo-32587: Make winreg.REG_MULTI_SZ support PendingFileRenameOperations

* Address review comments.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@ZackerySpytz @websurfer5
bpo-32587: Make winreg.REG_MULTI_SZ support zero-length strings (pyth…
f799a7e 
…on#13239)

* bpo-32587: Make winreg.REG_MULTI_SZ support PendingFileRenameOperations

* Address review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eryksun eryksun eryksun left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @bedevere-bot @miss-islington @eryksun @zooba @the-knights-who-say-ni