Skip to content

gh-131852: Filter out POT-Creation-Date in msgfmt#131880

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
StanFromIreland:pot-creation-date
Apr 5, 2025
Merged

gh-131852: Filter out POT-Creation-Date in msgfmt#131880
serhiy-storchaka merged 5 commits into
python:mainfrom
StanFromIreland:pot-creation-date

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Mar 29, 2025

Copy link
Copy Markdown
Member

The snapshot json seems fine, no need for a new test IMO

@StanFromIreland

Copy link
Copy Markdown
Member Author

cc @tomasr8 @serhiy-storchaka

@StanFromIreland
StanFromIreland marked this pull request as ready for review March 29, 2025 17:50
Comment thread Tools/i18n/msgfmt.py Outdated
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@StanFromIreland

StanFromIreland commented Apr 5, 2025

Copy link
Copy Markdown
Member Author

Friendly ping @serhiy-storchaka :-)

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread Tools/i18n/msgfmt.py Outdated
Comment thread Tools/i18n/msgfmt.py
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka
serhiy-storchaka merged commit ad6a032 into python:main Apr 5, 2025
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Apr 7, 2025
@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 7, 2025
)

(cherry picked from commit ad6a032)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 7, 2025
)

(cherry picked from commit ad6a032)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app

bedevere-app Bot commented Apr 7, 2025

Copy link
Copy Markdown

GH-132216 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 7, 2025
@bedevere-app

bedevere-app Bot commented Apr 7, 2025

Copy link
Copy Markdown

GH-132217 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Apr 7, 2025
serhiy-storchaka pushed a commit that referenced this pull request Apr 7, 2025
…H-132216)

(cherry picked from commit ad6a032)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Apr 7, 2025
…H-132217)

(cherry picked from commit ad6a032)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@StanFromIreland
StanFromIreland deleted the pot-creation-date branch April 7, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants