bpo-36869: Avoid warning of unused variables #13182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When run ```./configure && make -j4``` there are two warnings on Object/dictobject.c file about ix and hash variable are not used. Zachary Ware make me note that when _PyObject_ASSERT is call and NDEBUG is defined that expand to ((void)0). So this PR add a #ifndef check to avoid the warnings.
Member
|
Note that this function does nothing when NDEBUG is defined. Add it in top of the function, and add |
Contributor
Author
|
Thanks for your comment @methane, I made the change I will open a issue on bpo |
eamanu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run
./configure && make -j4there are two warnings onObject/dictobject.c file about ix and hash variable are not used.
Zachary Ware make me note that when _PyObject_ASSERT is call and NDEBUG
is defined that expand to ((void)0).
So this PR add a #ifndef check to avoid the warnings.
https://bugs.python.org/issue36869