gh-131670: Fix crash in anext() when __anext__ is sync and raises#131682
Merged
Conversation
picnixz
approved these changes
Mar 24, 2025
picnixz
left a comment
picnixz
left a comment
Member
There was a problem hiding this comment.
One suggestion otherwise LGTM.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
sobolevn
added
needs backport to 3.12
Member
Author
|
This crash happens down to 3.11 :( |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 24, 2025
…raises (pythonGH-131682) (cherry picked from commit 929afd1) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-131686 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 24, 2025
…raises (pythonGH-131682) (cherry picked from commit 929afd1) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-131687 is a backport of this pull request to the 3.12 branch. |
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 1, 2025
…raises (python#131682) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anext(A(), default)crashes whenStopAsyncIterationis raised by a synchronous__anext__#131670