Repository navigation
gh-126703: add freelist for ints with small number of digits - #129638
eendebakpt wants to merge 10 commits into
Conversation
| assert(is_medium_int(x)); | ||
|
|
||
| PyLongObject *v = (PyLongObject *)_Py_FREELIST_POP(PyLongObject, ints); | ||
| PyLongObject *v = (PyLongObject *)_Py_FREELIST_POP(PyLongObject, ints[1]); |
There was a problem hiding this comment.
Why ints[1] is used here?
Maybe some comment on it will be useful?
There was a problem hiding this comment.
Here we need only ndigits==1 integers.
New implementation uses several free lists (though, ints[0] isn't used).
There was a problem hiding this comment.
ints[0] is indeed not used. It takes a tiny bit of extra memory, but makes the code cleaner.
| _Py_FREELIST_FREE(ints, self, PyObject_Free); | ||
| if (PyLong_CheckExact(self)) { | ||
| if (!maybe_freelist_push(self)) { | ||
| PyObject_Free(self); |
There was a problem hiding this comment.
Is it equivalent to run PyObject_Free(self) and to run Py_TYPE(self)->tp_free(self) for integers with PyLong_MAXSAVESIZE or more digits?
There was a problem hiding this comment.
It is for exact ints (but might not be for subclasses).
|
This PR is stale because it has been open for 30 days with no activity. |
|
This PR is stale because it has been open for 90 days with no activity. |
Benchmark:
The
bench_intis not affected since the compact ints already have a freelist in current main. Thebench_idis a microbenchmark that does minimal amount of work. Thebench_gcdandbench_uuid8are benchmarks that are representative for real code.Statistics for the number of allocations saved can be found in the corresponding issue.
Benchmark script: