Skip to content

gh-67206: document that string.printable is not printable in the POSIX sense#128820

Merged
picnixz merged 6 commits into
python:mainfrom
picnixz:doc/string/is-printable-67206
Jan 14, 2025
Merged

gh-67206: document that string.printable is not printable in the POSIX sense#128820
picnixz merged 6 commits into
python:mainfrom
picnixz:doc/string/is-printable-67206

Conversation

@picnixz

@picnixz picnixz commented Jan 14, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Jan 14, 2025
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir awaiting core review labels Jan 14, 2025
@picnixz
picnixz requested review from bitdancer and vstinner January 14, 2025 10:12
vstinner
vstinner reviewed Jan 14, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Documentation/2025-01-14-11-06-41.gh-issue-67206.LYKmi5.rst Outdated
@picnixz picnixz changed the title gh-67206: document that string.printable is not printable in sense of POSIX and RFC 8522 gh-67206: document that string.printable is not printable in the sense of POSIX and RFC 8522 Jan 14, 2025
vstinner
vstinner reviewed Jan 14, 2025
View reviewed changes
Comment thread Doc/library/string.rst Outdated
@picnixz picnixz changed the title gh-67206: document that string.printable is not printable in the sense of POSIX and RFC 8522 gh-67206: document that string.printable is not printable in the sense of POSIX and RFC 1522 Jan 14, 2025
@picnixz picnixz changed the title gh-67206: document that string.printable is not printable in the sense of POSIX and RFC 1522 gh-67206: document that string.printable is not printable in the sense of POSIX and RFC Jan 14, 2025
@picnixz picnixz changed the title gh-67206: document that string.printable is not printable in the sense of POSIX and RFC gh-67206: document that string.printable is not printable in the POSIX sense Jan 14, 2025
@picnixz
picnixz requested a review from vstinner January 14, 2025 15:46
vstinner
vstinner approved these changes Jan 14, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz

picnixz commented Jan 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

I will reuse the title of the PR as the commit title and use an empty body message (it's easier to read the diff in this case)

@picnixz
picnixz merged commit d906bde into python:main Jan 14, 2025
@picnixz
picnixz deleted the doc/string/is-printable-67206 branch January 14, 2025 16:07
@picnixz picnixz added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 14, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 14, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jan 14, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@picnixz picnixz removed the needs backport to 3.13 bugs and security fixes label Jan 14, 2025
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jan 14, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 14, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jan 14, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 15, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 15, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jan 15, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@ambv ambv added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 15, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 15, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jan 15, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 15, 2025
@picnixz @miss-islington
pythongh-67206: Document that string.printable is not printable in …
096833a 
…the POSIX sense (pythonGH-128820)

(cherry picked from commit d906bde)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@ambv ambv added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 15, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 15, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jan 15, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 15, 2025
@picnixz @miss-islington
pythongh-67206: Document that string.printable is not printable in …
2b4f89a 
…the POSIX sense (pythonGH-128820)

(cherry picked from commit d906bde)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Jan 15, 2025

Copy link
Copy Markdown

GH-128867 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 15, 2025
@picnixz @miss-islington
pythongh-67206: Document that string.printable is not printable in …
25c2d15 
…the POSIX sense (pythonGH-128820)

(cherry picked from commit d906bde)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 15, 2025
@bedevere-app

bedevere-app Bot commented Jan 15, 2025

Copy link
Copy Markdown

GH-128868 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jan 15, 2025
picnixz added a commit that referenced this pull request Jan 15, 2025
@miss-islington @picnixz
[3.13] gh-67206: Document that string.printable is not printable in…
639e0f3 
… the POSIX sense (GH-128820) (#128868)

gh-67206: Document that `string.printable` is not printable in the POSIX sense (GH-128820)
(cherry picked from commit d906bde)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit that referenced this pull request Jan 15, 2025
@miss-islington @picnixz
[3.12] gh-67206: Document that string.printable is not printable in…
85255c4 
… the POSIX sense (GH-128820) (#128867)

gh-67206: Document that `string.printable` is not printable in the POSIX sense (GH-128820)
(cherry picked from commit d906bde)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@bitdancer bitdancer Awaiting requested review from bitdancer

Assignees

@picnixz picnixz

Labels

docs Documentation in the Doc dir

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz @vstinner @ambv