Skip to content

bpo-36650: Fix handling of empty keyword args in C version of lru_cache.#12881

Merged
rhettinger merged 4 commits into
python:masterfrom
rhettinger:fix_lru_empty_dict
Apr 20, 2019
Merged

bpo-36650: Fix handling of empty keyword args in C version of lru_cache.#12881
rhettinger merged 4 commits into
python:masterfrom
rhettinger:fix_lru_empty_dict

Conversation

@rhettinger

@rhettinger rhettinger commented Apr 20, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@rhettinger rhettinger added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Apr 20, 2019
serhiy-storchaka
serhiy-storchaka reviewed Apr 20, 2019
View reviewed changes
Comment thread Modules/_functoolsmodule.c Outdated
serhiy-storchaka
serhiy-storchaka approved these changes Apr 20, 2019
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just added few nits.

Comment thread Modules/_functoolsmodule.c
Comment thread Modules/_functoolsmodule.c Outdated
jaraco
jaraco approved these changes Apr 20, 2019
View reviewed changes
Comment thread Lib/test/test_functools.py
@rhettinger
rhettinger merged commit 14adbd4 into python:master Apr 20, 2019
@miss-islington

miss-islington commented Apr 20, 2019

Copy link
Copy Markdown
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 20, 2019
@rhettinger @miss-islington
bpo-36650: Fix handling of empty keyword args in C version of lru_cac…
44fd879 
…he. (pythonGH-12881)

(cherry picked from commit 14adbd4)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Apr 20, 2019

Copy link
Copy Markdown

GH-12888 is a backport of this pull request to the 3.7 branch.

rhettinger added a commit that referenced this pull request Apr 20, 2019
@miss-islington @rhettinger
bpo-36650: Fix handling of empty keyword args in C version of lru_cac…
8b30ee8 
…he. (GH-12881) (GH-12888)

(cherry picked from commit 14adbd4)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rhettinger @miss-islington @bedevere-bot @jaraco @serhiy-storchaka @the-knights-who-say-ni