bpo-36641: Add "const" to PyDoc_VAR macro#12854
Merged
Merged
Conversation
It reduces "data" segment in python about 200KB.
| @@ -0,0 +1,2 @@ | |||
| :c:macro:`PyDoc_VAR(name)` and :c:macro:`PyDoc_STRVAR(name,str)`` now create | |||
Member
There was a problem hiding this comment.
This should be rather in the "C API" section.
serhiy-storchaka
approved these changes
Apr 16, 2019
Co-Authored-By: methane <songofacandy@gmail.com>
Member
|
Maybe a naive question does this make any difference in Windows too? I could see this was suggested in past by @serhiy-storchaka https://bugs.python.org/issue20323#msg236599 . |
vstinner
requested changes
Apr 16, 2019
|
When you're done making the requested changes, leave the comment: |
vstinner
reviewed
Apr 16, 2019
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM if you fix the NEWS entry.
Co-Authored-By: methane <songofacandy@gmail.com>
vstinner
approved these changes
Apr 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36641