Skip to content

bpo-30202 : Update test.test_importlib.test_abc to test find_spec() #12847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 5 commits into from
Jun 21, 2019
Merged

bpo-30202 : Update test.test_importlib.test_abc to test find_spec() #12847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ef484f
Update test.test_importlib.test_abc to test find_spec
nanjekyejoannah Apr 15, 2019
a49652e
Update test.test_importlib.test_abc to test find_spec
nanjekyejoannah Apr 15, 2019
e5caf30
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 15, 2019
9d60208
Add explicit test for find_module
nanjekyejoannah Jun 6, 2019
4905642
Remove deprecation warnings for find_spec
nanjekyejoannah Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions Lib/test/test_importlib/test_abc.py
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,23 +357,36 @@ def find_spec(self, fullname, path, target=None):

return MetaPathSpecFinder()

def test_no_spec(self):
def test_find_module(self):
finder = self.finder(None)
path = ['a', 'b', 'c']
name = 'blah'
with self.assertWarns(DeprecationWarning):
found = finder.find_module(name, path)
self.assertIsNone(found)

def test_find_spec_with_explicit_target(self):
loader = object()
spec = self.util.spec_from_loader('blah', loader)
finder = self.finder(spec)
found = finder.find_spec('blah', 'blah', None)
self.assertEqual(found, spec)

def test_no_spec(self):
finder = self.finder(None)
path = ['a', 'b', 'c']
name = 'blah'
found = finder.find_spec(name, path, None)
self.assertIsNone(found)
self.assertEqual(name, finder.called_for[0])
self.assertEqual(path, finder.called_for[1])

def test_spec(self):
loader = object()
spec = self.util.spec_from_loader('blah', loader)
finder = self.finder(spec)
with self.assertWarns(DeprecationWarning):
found = finder.find_module('blah', None)
self.assertIs(found, spec.loader)
found = finder.find_spec('blah', None)
self.assertIs(found, spec)


(Frozen_MPFFindModuleTests,
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2019-04-15-19-05-35.bpo-30202.Wt7INj.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update ``test.test_importlib.test_abc`` to test ``find_spec()``.