gh-128404: split test_asyncgen.py into tests that require a working socket and tests that do not - #128443
Open
graingert wants to merge 9 commits into
Open
gh-128404: split test_asyncgen.py into tests that require a working socket and tests that do not#128443graingert wants to merge 9 commits into
graingert wants to merge 9 commits into
Conversation
graingert
commented
Jan 3, 2025
graingert
marked this pull request as ready for review
January 3, 2025 11:47
graingert
changed the title
|
This PR is stale because it has been open for 30 days with no activity. |
graingert
force-pushed
the
remove-requires-working-socket-from-some-of-test-asyncgen
branch
from
August 31, 2026 18:49
8d86513 to
be03eda
Compare
github-actions
Bot
removed
the
stale
The last import_module() call site went away when
`asyncio = import_module("asyncio")` became a plain import, leaving
the import orphaned and tripping ruff's F401 in the lint job.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
It does not use the event loop, so the tearDown assertion that the loop was used fails when it stays in AsyncGenAsyncioTest.
graingert
force-pushed
the
remove-requires-working-socket-from-some-of-test-asyncgen
branch
from
September 2, 2026 07:35
cb65eb5 to
2c74bcf
Compare
Contributor
Author
|
@Eclips4 I've rebased this and it's ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.