bpo-36625: Remove obsolete comments from docstrings in fractions module#12822
Merged
Conversation
mdickinson
approved these changes
Apr 14, 2019
mdickinson
left a comment
mdickinson
left a comment
Member
There was a problem hiding this comment.
LGTM. Does this need a Misc/NEWS entry?
Contributor
|
LGTM, too. I don't think this merits bothering users with a "What's new" entry. |
Member
|
Agreed that it doesn't need a what's new entry, but it should still have a Misc/NEWS entry, on general principles. (Specfically, these general principles: https://devguide.python.org/committing/#what-s-new-and-news-entries.) @jmolinski Please could you use the |
Contributor
Author
|
@mdickinson of course, I added the Misc/NEWS entry. |
Member
|
All done. @jmolinski Thank you very much for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated 3 docstrings in
fractions.Fractioncontaining comments referring to python 3.0.New docstrings are consistent with other docstrings in the fractions module.
https://bugs.python.org/issue36625