gh-127975: Avoid reusing quote types in ast.unparse if not needed#127980
Merged
Conversation
hauntsaninja
force-pushed
the
gh-127975
branch
from
December 16, 2024 08:12
dd4fc04 to
16e4fa7
Compare
hauntsaninja
marked this pull request as ready for review
December 20, 2024 08:43
hauntsaninja
requested review from
Eclips4,
JelleZijlstra and
isidentical
as code owners
December 20, 2024 08:43
JelleZijlstra
approved these changes
Dec 20, 2024
Eclips4
approved these changes
Dec 20, 2024
hauntsaninja
enabled auto-merge (squash)
January 31, 2025 06:52
hauntsaninja
added
needs backport to 3.12
|
Thanks @hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 2, 2025
…ed (pythonGH-127980) (cherry picked from commit 8df5193) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
|
GH-129600 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 2, 2025
…ed (pythonGH-127980) (cherry picked from commit 8df5193) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
|
GH-129601 is a backport of this pull request to the 3.12 branch. |
hauntsaninja
added a commit
that referenced
this pull request
Feb 2, 2025
hauntsaninja
added a commit
that referenced
this pull request
Feb 3, 2025
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pablo was curious about a PR, so opening this as a draft
ast.unparseis needlessly "hip" for f-string quotes in Python 3.12+ #127975