Merged
Conversation
skirpichev
reviewed
Dec 16, 2024
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
skirpichev
requested changes
Dec 16, 2024
skirpichev
left a comment
skirpichev
left a comment
Member
There was a problem hiding this comment.
Looks good, but please add news and document that in whatsnew/3.14.rst (C API Changes->Deprecated).
ghost
requested a review
from skirpichev
December 16, 2024 07:52
Author
|
Thanks. Added news and whatsnew entry. |
encukou
reviewed
Dec 16, 2024
skirpichev
approved these changes
Dec 16, 2024
skirpichev
left a comment
skirpichev
left a comment
Member
There was a problem hiding this comment.
LGTM, but I second on above suggestion.
Co-authored-by: Petr Viktorin <encukou@gmail.com>
ghost
requested a review
from encukou
December 16, 2024 10:23
|
|
||
| Alias for :c:func:`PySequence_Contains`. | ||
|
|
||
| .. deprecated:: 3.14 |
Member
There was a problem hiding this comment.
We have this fancy thing these days:
Suggested change
| .. deprecated:: 3.14 | |
| .. deprecated:: next | |
Member
There was a problem hiding this comment.
We do, and it makes backporting easier, but backporting a deprecation doesn't make much sense :)
ghost
deleted the
doc-fix-2
branch
December 16, 2024 14:40
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…GH-127979) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-127896 .
📚 Documentation preview 📚: https://cpython-previews--127979.org.readthedocs.build/en/127979/c-api/sequence.html#c.PySequence_In