Skip to content

bpo-36588: For AIX remove major version from sys.platform #12787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 4 commits into from
Apr 12, 2019
Merged

bpo-36588: For AIX remove major version from sys.platform #12787

vstinner merged 4 commits into from
Apr 12, 2019

Conversation

@aixtools
Copy link
Contributor

@aixtools aixtools commented Apr 11, 2019 •
edited by bedevere-bot
Loading

vstinner
vstinner requested changes Apr 11, 2019
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Apr 11, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@aixtools
Copy link
Contributor Author

aixtools commented Apr 11, 2019

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Apr 11, 2019

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

vstinner
vstinner approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just revert the newline change.

ZackerySpytz
ZackerySpytz reviewed Apr 11, 2019
View reviewed changes
@vstinner vstinner merged commit 9d949f7 into python:master Apr 12, 2019
@vstinner
Copy link
Member

vstinner commented Apr 12, 2019

Thanks @aixtools: that's what I expected when I wrote "properly document the change" ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

+1 more reviewer

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aixtools @bedevere-bot @vstinner @ZackerySpytz @the-knights-who-say-ni