bpo-36601: clarify signal handler comment and remove unnecessary pid check.#12784
Merged
Conversation
Member
|
I suggest adding a NEWS entry that says something along the lines of "A believed now-meaningless internal check for getpid() == main_pid was removed from Python's signal handler." |
gpshead
approved these changes
Apr 12, 2019
Contributor
Author
Done. |
Contributor
Author
|
This was set to "awaiting merge" almost 2 weeks ago. Can this actually be merged please? |
Member
|
I find |
Member
|
heh thanks, i cleaned up the news entry wording. |
gpshead
approved these changes
May 10, 2019
gpshead
changed the title
Contributor
|
@jdemeyer: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36601