Skip to content

gh-87506: Document that json.load*() can raise UnicodeDecodeError#127355

Merged
erlend-aasland merged 6 commits into
python:mainfrom
srinivasreddy:gh_87506
Jan 8, 2025
Merged

gh-87506: Document that json.load*() can raise UnicodeDecodeError#127355
erlend-aasland merged 6 commits into
python:mainfrom
srinivasreddy:gh_87506

Conversation

@srinivasreddy

@srinivasreddy srinivasreddy commented Nov 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

gh-87506: Improve the documentation for json.load() and json.loads()

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 28, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 28, 2024
Closed
@srinivasreddy

srinivasreddy commented Nov 28, 2024

Copy link
Copy Markdown
Contributor Author

Since @serhiy-storchaka moved this into JSON issues, I am raising this PR.
If @rhettinger still feel that it is okay to forgo this documentation update since we cannot,(should not) comprehensively document every exception. And in that case we can successfully close the issue.

@skirpichev skirpichev changed the title gh-87505: Improve the documentation for json.load() and json.loads() gh-87506: Improve the documentation for json.load() and json.loads() Nov 28, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 28, 2024
Closed
serhiy-storchaka
serhiy-storchaka reviewed Nov 28, 2024
View reviewed changes
Comment thread Doc/library/json.rst Outdated
@rhettinger rhettinger removed their request for review November 29, 2024 03:39
@erlend-aasland erlend-aasland self-requested a review January 4, 2025 17:42
@erlend-aasland erlend-aasland self-assigned this Jan 4, 2025
@erlend-aasland

This comment was marked as resolved.

Sign in to view
@erlend-aasland

erlend-aasland commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

@srinivasreddy, please pull in main and resolve the conflicts.

@cjw296

cjw296 commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

@erlend-aasland - please bear in mind that "pull in main" results in an awful lot of unrelated folks getting spammed by this PR. Better would be to rebase the branch on main.

@cjw296 cjw296 removed their request for review January 8, 2025 06:41
@methane

methane commented Jan 8, 2025

Copy link
Copy Markdown
Member

rebase on main also trigger this PR corruption.
Recommended way is git pull upstream main.

See these:

@erlend-aasland

erlend-aasland commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

@erlend-aasland - please bear in mind that "pull in main" results in an awful lot of unrelated folks getting spammed by this PR. Better would be to rebase the branch on main.

This is absolutely not correct.

erlend-aasland
erlend-aasland reviewed Jan 8, 2025
View reviewed changes
Comment thread Doc/library/json.rst Outdated
Comment thread Doc/library/json.rst Outdated
srinivasreddy and others added 3 commits January 8, 2025 12:55
@srinivasreddy @erlend-aasland
Update Doc/library/json.rst
08b8f3e 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@srinivasreddy
Address review comments
b7bd2b2
@srinivasreddy
Address review comments
725e155
erlend-aasland
erlend-aasland approved these changes Jan 8, 2025
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miss-islington-app

This comment was marked as outdated.

Sign in to view
@bedevere-app

bedevere-app Bot commented Jan 8, 2025

Copy link
Copy Markdown

GH-128607 is a backport of this pull request to the 3.13 branch.

@bedevere-app

bedevere-app Bot commented Jan 8, 2025

Copy link
Copy Markdown

GH-128608 is a backport of this pull request to the 3.12 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger left review comments
@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

@erlend-aasland erlend-aasland

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

json.load() can raise UnicodeDecodeError, but this is not documented

6 participants

@srinivasreddy @erlend-aasland @cjw296 @methane @rhettinger @serhiy-storchaka