bpo-36434: Properly handle writing errors in ZIP files.#12559
Merged
serhiy-storchaka merged 2 commits intoMar 30, 2019
Conversation
Errors during writing no longer prevent to properly close the ZIP file.
serhiy-storchaka
added
type-bug
tirkarthi
reviewed
Mar 26, 2019
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 30, 2019
Errors during writing no longer prevent to properly close the ZIP file. (cherry picked from commit 2524fde) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-12628 is a backport of this pull request to the 3.7 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Mar 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors during writing no longer prevent to properly close
the ZIP file.
https://bugs.python.org/issue36434