Skip to content

bpo-36425: Add Simplified Chinese to the language switcher#12537

Merged
JulienPalard merged 2 commits intopython:masterfrom
zhsj:zh-cn
Mar 28, 2019
Merged

bpo-36425: Add Simplified Chinese to the language switcher#12537
JulienPalard merged 2 commits intopython:masterfrom
zhsj:zh-cn

Conversation

@zhsj
Copy link
Copy Markdown
Contributor

@zhsj zhsj commented Mar 25, 2019

bpo-36425: Add Simplified Chinese to the language switcher

https://bugs.python.org/issue36425

Copy link
Copy Markdown
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to hear other opinions, but I think that NEWS is necessary here :-)

@JulienPalard
Copy link
Copy Markdown
Member

I concour with @eamanu, a NEWS entry would be great, it's not a minor change :)

If you feel it, you can mention it too in Doc/whatsnew/3.8.rst in a "Documentation improvements:" category like we announced french japanese and korean in Doc/whatsnew/3.7.rst

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @zhsj for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

GH-12608 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 28, 2019
…12537)

(cherry picked from commit 45a5fdb)

Co-authored-by: zhsj <zsj950618@gmail.com>
@zhsj zhsj deleted the zh-cn branch March 28, 2019 17:21
miss-islington added a commit that referenced this pull request Mar 28, 2019
(cherry picked from commit 45a5fdb)

Co-authored-by: zhsj <zsj950618@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants