bpo-36407: Fix writing indentations of CDATA section (xml.dom.minidom)#12514
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
scoder
left a comment
scoder
left a comment
There was a problem hiding this comment.
The fix looks good to me, thanks!
|
Test also looks good now. CLA pending. |
serhiy-storchaka
added
type-bug
|
Thanks @vsurjaninov for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7. |
|
Thanks @vsurjaninov for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Sorry, @vsurjaninov and @serhiy-storchaka, I could not cleanly backport this to |
|
GH-12578 is a backport of this pull request to the 2.7 branch. |
…). (pythonGH-12514) (cherry picked from commit 384b81d) Co-authored-by: Vladimir Surjaninov <vsurjaninov@gmail.com>
7 participants
bpo-36407: This little change fixes indentations when we are writing xml with CDATA section. Also a result document now can be parsed correctly as if we would write it without indentations.
https://bugs.python.org/issue36407