Skip to content

[3.7] bpo-23205: IDLE: Add tests and refactor grep's findfiles (GH-12203)#12512

Merged
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-d60f658-3.7
Mar 23, 2019
Merged

[3.7] bpo-23205: IDLE: Add tests and refactor grep's findfiles (GH-12203)#12512
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-d60f658-3.7

Conversation

@miss-islington

@miss-islington miss-islington commented Mar 23, 2019

Copy link
Copy Markdown
Contributor
  • Add tests for grep findfiles.
  • Move findfiles to module function.
  • Change findfiles to use os.walk.

Based on a patch by Al Sweigart.
(cherry picked from commit d60f658)

Co-authored-by: Cheryl Sabella cheryl.sabella@gmail.com

https://bugs.python.org/issue23205

)

* Add tests for grep findfiles.
* Move findfiles to module function.
* Change findfiles to use os.walk.

Based on a patch by Al Sweigart.
(cherry picked from commit d60f658)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

@csabella csabella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🤖

@miss-islington

Copy link
Copy Markdown
Contributor Author

@csabella: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit 5ab6650 into python:3.7 Mar 23, 2019
@miss-islington
miss-islington deleted the backport-d60f658-3.7 branch March 23, 2019 12:21
@miss-islington

Copy link
Copy Markdown
Contributor Author

@csabella: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants