bpo-36298: Raise ModuleNotFoundError in pyclbr when a module can't be found#12358
Merged
Conversation
mental32
reviewed
Mar 16, 2019
mental32
left a comment
mental32
left a comment
Contributor
There was a problem hiding this comment.
Reviewed diff (looks good), Interested to know your thoughts on the comments.
Member
|
@brettcannon Is there a particular reason you think this should be backported to 3.6? |
Member
Author
|
@ned-deily no, and since it's a change in exception it probably shouldn't be backported, so I have dropped the backporting idea. |
Contributor
|
@brettcannon: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, an
AttributeErrorwas raised due to trying to access an attribute that exists on specs but having receivedNoneinstead for a non-existent module.https://bugs.python.org/issue36298