Skip to content

gh-123363: Show string value of CONTAINS_OP oparg in dis#123387

Merged
sobolevn merged 8 commits into
python:mainfrom
Alexandr153:fix-issue-123363
Aug 28, 2024
Merged

gh-123363: Show string value of CONTAINS_OP oparg in dis#123387
sobolevn merged 8 commits into
python:mainfrom
Alexandr153:fix-issue-123363

Conversation

@Alexandr153

@Alexandr153 Alexandr153 commented Aug 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Result:

>>> echo 'a not in  b' | ./python.exe -m dis
  0           RESUME                   0

  1           LOAD_NAME                0 (a)
              LOAD_NAME                1 (b)
              CONTAINS_OP              1 (not in)
              RETURN_VALUE

>>> echo 'a in  b' | ./python.exe -m dis
  0           RESUME                   0

  1           LOAD_NAME                0 (a)
              LOAD_NAME                1 (b)
              CONTAINS_OP              0 (in)
              RETURN_VALUE

@ghost

ghost commented Aug 27, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

bedevere-app Bot commented Aug 27, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Alexandr153 Alexandr153 changed the title Show string value of CONTAINS_OP oparg in dis gh-123363: Show string value of CONTAINS_OP oparg in dis Aug 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 27, 2024
Closed
@bedevere-app

bedevere-app Bot commented Aug 27, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

picnixz
picnixz approved these changes Aug 27, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2024-08-27-12-11-00.gh-issue-123363.gKuJp6.rst
picnixz
picnixz reviewed Aug 27, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2024-08-27-12-11-00.gh-issue-123363.gKuJp6.rst Outdated
@Eclips4
Eclips4 requested a review from sobolevn August 28, 2024 05:37
Eclips4
Eclips4 approved these changes Aug 28, 2024
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

sobolevn
sobolevn approved these changes Aug 28, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevn
sobolevn merged commit 6a7765b into python:main Aug 28, 2024
@Alexandr153
Alexandr153 deleted the fix-issue-123363 branch April 18, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@sobolevn sobolevn sobolevn approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Alexandr153 @sobolevn @picnixz @Eclips4