Skip to content

gh-121268: remove workarounds for non-IEEE 754 systems in cmath #122716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Aug 9, 2024
Merged

gh-121268: remove workarounds for non-IEEE 754 systems in cmath #122716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aba316
gh-121268: remove workarounds for non-IEEE 754 systems in cmath
skirpichev Jul 17, 2024
470a59d
Merge branch 'main' into drop-cmath-legacy-121268
skirpichev Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-07-17-12-55-22.gh-issue-121268.41RmjR.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove workarounds for non-IEEE 754 systems in :mod:`cmath`.
17 changes: 3 additions & 14 deletions Modules/cmathmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,8 @@ cmath_acos_impl(PyObject *module, Py_complex z)
if (fabs(z.real) > CM_LARGE_DOUBLE || fabs(z.imag) > CM_LARGE_DOUBLE) {
/* avoid unnecessary overflow for large arguments */
r.real = atan2(fabs(z.imag), z.real);
/* split into cases to make sure that the branch cut has the
correct continuity on systems with unsigned zeros */
if (z.real < 0.) {
r.imag = -copysign(log(hypot(z.real/2., z.imag/2.)) +
M_LN2*2., z.imag);
} else {
r.imag = copysign(log(hypot(z.real/2., z.imag/2.)) +
M_LN2*2., -z.imag);
}
r.imag = -copysign(log(hypot(z.real/2., z.imag/2.)) +
M_LN2*2., z.imag);
} else {
s1.real = 1.-z.real;
s1.imag = -z.imag;
Expand Down Expand Up @@ -386,11 +379,7 @@ cmath_atanh_impl(PyObject *module, Py_complex z)
*/
h = hypot(z.real/2., z.imag/2.); /* safe from overflow */
r.real = z.real/4./h/h;
/* the two negations in the next line cancel each other out
except when working with unsigned zeros: they're there to
ensure that the branch cut has the correct continuity on
systems that don't support signed zeros */
r.imag = -copysign(Py_MATH_PI/2., -z.imag);
r.imag = copysign(Py_MATH_PI/2., z.imag);
errno = 0;
} else if (z.real == 1. && ay < CM_SQRT_DBL_MIN) {
/* C99 standard says: atanh(1+/-0.) should be inf +/- 0i */
Expand Down