Skip to content

gh-122631 Add video/3gpp and video/3gpp2 to mimetypes#122632

Open
robotmlg wants to merge 9 commits into
python:mainfrom
robotmlg:fix-issue-122631-3gp-video-mime-types
Open

gh-122631 Add video/3gpp and video/3gpp2 to mimetypes#122632
robotmlg wants to merge 9 commits into
python:mainfrom
robotmlg:fix-issue-122631-3gp-video-mime-types

Conversation

@robotmlg

@robotmlg robotmlg commented Aug 2, 2024

Copy link
Copy Markdown

@robotmlg
robotmlg requested a review from a team as a code owner August 2, 2024 20:02
@ghost

ghost commented Aug 2, 2024

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

bedevere-app Bot commented Aug 2, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Comment thread Misc/NEWS.d/next/Library/2024-08-02-20-02-38.gh-issue-122631.p4QdB2.rst Outdated
…4QdB2.rst

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you note, the audio/ versions already exist:

cpython/Lib/mimetypes.py

Lines 527 to 530 in efcd65c

'.3gp' : 'audio/3gpp',
'.3gpp' : 'audio/3gpp',
'.3g2' : 'audio/3gpp2',
'.3gpp2' : 'audio/3gpp2',

The suffixes are the same, though, so this would overwrite as they appear later in the dict. Can you think of a way to fix that?

A

Comment thread Lib/test/test_mimetypes.py
Comment thread Misc/NEWS.d/next/Library/2024-08-02-20-02-38.gh-issue-122631.p4QdB2.rst Outdated
@bedevere-app

bedevere-app Bot commented Aug 3, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@AA-Turner AA-Turner added the pending The issue will be closed if no feedback is provided label Aug 3, 2024
@robotmlg

robotmlg commented Sep 3, 2024

Copy link
Copy Markdown
Author

@AA-Turner I have made the requested changes; please review again.

I think ideally types_map would also be a dict[str, list[str]] like types_map_inv is, so that every extension would map to a list of types. But that would be a pretty big breaking change for my first PR here (since types_map gets exported), lemme know if you think I should tackle that instead of my more band-aid solution here.

(Also I'm not sure what's going on with my NEWS build errors, would appreciate any pointers there.)

EDIT: I put up a PR on my fork of how I would do the breaking version. I do think it's cleaner, and more future-proof, but obviously it's a breaking change on types_map and presumably we'd have to go through channels for that. Lemme know your thoughts. robotmlg#1

@bedevere-app

bedevere-app Bot commented Sep 3, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@AA-Turner: please review the changes made to this pull request.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting change review pending The issue will be closed if no feedback is provided stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants