bpo-35967 resolve platform.processor late#12239
Merged
jaraco merged 18 commits intopython:masterfrom Apr 16, 2020
jaraco:feature/35967-platform-processor-resolved-late
Merged
bpo-35967 resolve platform.processor late#12239jaraco merged 18 commits intopython:masterfrom jaraco:feature/35967-platform-processor-resolved-late
jaraco merged 18 commits intopython:masterfrom
jaraco:feature/35967-platform-processor-resolved-late
Conversation
…nt on uname -p in a subprocess).
…ferent systems (probably a fool's errand), simply assert that except for the known platform variance, uname().processor matches the output of 'uname -p'
…ure/35967-platform-processor-resolved-late
Member
Author
|
I see the appveyor tests failed, but I'm going to assume that's a spurious failure, since it doesn't happen on the Azure pipelines and doesn't seem to be relevant to the test_platform tests. |
Member
|
reopening to retrigger CI. (we removed appveyor recently) |
Member
Author
|
In the aforementioned issue, Marc agreed this approach is suitable as long as it has tests, which it does. Is anything more needed? |
jaraco
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
… had any effect). Rely on _unknown_as_blank to replace unknown with blank.
jaraco
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
Author
|
Failed checks look unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35967