Skip to content

bpo-36157:Document PyInterpreterState_Main()#12238

Merged
miss-islington merged 2 commits into
python:masterfrom
nanjekyejoannah:issue36157
Apr 1, 2019
Merged

bpo-36157:Document PyInterpreterState_Main()#12238
miss-islington merged 2 commits into
python:masterfrom
nanjekyejoannah:issue36157

Conversation

@nanjekyejoannah

@nanjekyejoannah nanjekyejoannah commented Mar 8, 2019

Copy link
Copy Markdown
Contributor

I have added documentation for PyInterpreterState_Main().
I chose to place it under Advanced Debugger Support together with similar functions like PyInterpreterState_Head(), PyInterpreterState_Next(), and PyInterpreterState_ThreadHead() .

https://bugs.python.org/issue36157

@nanjekyejoannah

Copy link
Copy Markdown
Contributor Author

cc @ericsnowcurrently and @ncoghlan

@ericsnowcurrently

Copy link
Copy Markdown
Member

Thanks for working on this, @nanjekyejoannah. This PR may be a good opportunity to make sure the C-API docs are clear about what the "main" interpreter is. However, if you don't want to worry about that here it can be dealt with separately. I'll merge this the next time I take a look (giving you a few days to respond) if you go with the latter or don't respond. :)

@nanjekyejoannah

nanjekyejoannah commented Mar 30, 2019

Copy link
Copy Markdown
Contributor Author

@ericsnowcurrently please go on and merge this. I will work on making the C-API docs more clear in a separate PR. I opened an issue on the bug tracker to track this.

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-12650 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 1, 2019
I have added documentation for `PyInterpreterState_Main()`.
 I chose to place it under Advanced Debugger Support together with similar functions like `PyInterpreterState_Head()`, `PyInterpreterState_Next(`), and `PyInterpreterState_ThreadHead()` .

https://bugs.python.org/issue36157
(cherry picked from commit 8c61739)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Apr 1, 2019
I have added documentation for `PyInterpreterState_Main()`.
 I chose to place it under Advanced Debugger Support together with similar functions like `PyInterpreterState_Head()`, `PyInterpreterState_Next(`), and `PyInterpreterState_ThreadHead()` .

https://bugs.python.org/issue36157
(cherry picked from commit 8c61739)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants