bpo-36227: ElementTree.tostring() default_namespace argument#12225
Merged
Conversation
Contributor
Author
|
This PR also fixes bpo-31256 (https://bugs.python.org/issue31256): xml.etree.ElementTree: add support for doctype in tostring method |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Also, it would be nice to add similar tests for the write() method.
| elem = ET.XML('<body xmlns="http://effbot.org/ns"><tag/></body>') | ||
| self.assertEqual( | ||
| ET.tostringlist(elem, encoding='unicode')[0:2], | ||
| ['<ns0:body', ' xmlns:ns0="http://effbot.org/ns"'] |
Member
There was a problem hiding this comment.
The exact splitting on chunks is an implementation detail. Test the value of b''.join(ET.tostringlist(elem, ...)) instead.
Co-Authored-By: codeape2 <bernt.brenna@gmail.com>
Contributor
Author
|
@serhiy-storchaka I will look into your comments after the weekend. |
added 8 commits
March 29, 2019 10:45
Contributor
Author
|
@serhiy-storchaka I pushed commits addressing your comments. I did not add any similar tests for .write() however, since .write() is in effect tested by tostring(). |
serhiy-storchaka
approved these changes
Mar 31, 2019
Member
|
LGTM. @scoder, could you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36227